[
https://issues.apache.org/jira/browse/ZOOKEEPER-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858800#comment-16858800
]
Hudson commented on ZOOKEEPER-3416:
-----------------------------------
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #560 (See
[https://builds.apache.org/job/ZooKeeper-trunk/560/])
ZOOKEEPER-3416: Remove redundant ServerCnxnFactoryAccessor. (eolivelli: rev
89e7e55811b7115a9155f25cd572520055af00fc)
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/WatcherTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/LoadFromLogTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientBase.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/TruncateTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxnFactory.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/SessionTest.java
* (delete)
zookeeper-server/src/test/java/org/apache/zookeeper/server/ServerCnxnFactoryAccessor.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/RemoveWatchesTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ZooKeeperQuotaTest.java
> Remove redundant ServerCnxnFactoryAccessor
> ------------------------------------------
>
> Key: ZOOKEEPER-3416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3416
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.6.0
> Reporter: Michael Han
> Assignee: Michael Han
> Priority: Minor
> Labels: Twitter, pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We have two ways to access the private zkServer inside ServerCnxnFactory, and
> there is really no need to keep maintaining both. We could remove
> ServerCnxnFactoryAccessor when we added the public accessor for
> ServerCnxnFactory in ZOOKEEPER-1346, but we did not.
> The solution is to consolidate all access of the zkServer through the public
> accessor of ServerCnxnFactory. The end result is cleaner code base and less
> confusion.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
