[
https://issues.apache.org/jira/browse/ZOOKEEPER-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870391#comment-16870391
]
Enrico Olivelli commented on ZOOKEEPER-3440:
--------------------------------------------
In the patch I had to clean up the exclusions list as rat was not passing on "C
client" and on "cotrib" module.
I never dug into contrib but now I see that those modules are full of
unlicensed files.
We really should take care of this problem and fix the files (or drop the
unused contrib modules).
Personally I would keep only the zkpython module on the repository and move it
out of "contrib", making it a first class citizen next to the C client
> Fix Apache RAT check by excluding binary files (images)
> -------------------------------------------------------
>
> Key: ZOOKEEPER-3440
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3440
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, documentation
> Affects Versions: 3.6.0
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I see this error on Jenkins as we are missing the exclusion for the images of
> the docs.
> {code:java}
> Unapproved licenses:
>
> /home/jenkins/jenkins-slave/workspace/zookeeper-master-maven/zookeeper-docs/src/main/resources/markdown/images/state_dia.dia
> {code}
> We should also add this check to the precommit job on Travis (this will be
> part of the commit) and on CI (this is a manual configuration, to be done
> after fixing this issue)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
