[
https://issues.apache.org/jira/browse/ZOOKEEPER-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891540#comment-16891540
]
Hadoop QA commented on ZOOKEEPER-3418:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4069//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4069//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4069//console
This message is automatically generated.
> Improve quorum throughput through eager ACL checks of requests on local
> servers
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3418
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3418
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.6.0
> Reporter: Michael Han
> Assignee: Michael Han
> Priority: Major
> Labels: Twitter, pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Serving write requests that change the state of the system requires quorum
> operations, and in some cases, the quorum operations can be avoided if the
> requests are doomed to fail. ACL check failure is such a case. To optimize
> for this case, we elevate the ACL check logic and perform eager ACL check on
> local server (where the requests are received), and fail fast, before sending
> the requests to leader.
> As with any features, there is a feature flag that can control this feature
> on, or off (default). This feature is also forward compatible in that for new
> any new Op code (and some existing Op code we did not explicit check
> against), they will pass the check and (potentially) fail on leader side,
> instead of being prematurely filtered out on local server.
> The end result is better throughput and stability of the quorum for certain
> workloads.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
