[
https://issues.apache.org/jira/browse/ZOOKEEPER-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891970#comment-16891970
]
TisonKun commented on ZOOKEEPER-3465:
-------------------------------------
Hi [~maoling] and [~eolivelli], after an investigation of Google's and
BookKeeper's checkstyle configuration. I have to point out that zookeeper is
more likely to obey BookKeeper's configruation generally. If we use Google's
configuration, rules like those of indent would cause a wide range of code
conflict. Besides, BookKeeper's configuration includes rules used in ZooKeeper
simple configuration.
I tend to use BookKeeper's checkstyle configuration and locally test
compatibility.
A pr towards this JIRA would be ready in minutes.
> Introduce BookKeeper checkstyle configuration
> ---------------------------------------------
>
> Key: ZOOKEEPER-3465
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3465
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build
> Reporter: TisonKun
> Priority: Major
> Fix For: 3.6.0
>
>
> For enable BookKeeper checkstyle configuration, we introduce a silent
> configuration.
> Also
> 1. remove FileContentsHolder rule for checkstyle version compatibility.
> 2. check all rules in the simple checkstyle configuration included.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
