[
https://issues.apache.org/jira/browse/ZOOKEEPER-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897828#comment-16897828
]
Hadoop QA commented on ZOOKEEPER-3473:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4089//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4089//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4089//console
This message is automatically generated.
> Improving successful TLS handshake throughput with concurrent control
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-3473
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3473
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When there are lots of clients trying to re-establish sessions, there might
> be lots of half finished handshake timed out, and those failed ones keep
> reconnecting to another server and restarting the handshake from beginning
> again, which caused herd effect.
>
> And the number of total ZK sessions could be supported within session timeout
> are impacted a lot after enabling TLS.
>
> To improve the throughput, we added the TLS concurrent control to reduce the
> herd effect, and from out benchmark this doubled the sessions we could
> support within session timeout.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
