[
https://issues.apache.org/jira/browse/ZOOKEEPER-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917828#comment-16917828
]
sonymoon commented on ZOOKEEPER-3523:
-------------------------------------
Thanks for your inviting [~Tison]! I am not a committer nor a contributor, and
I am still learning stuffs about ZooKeeper.I would have little concerns of my
helpless review.
BTW, I have a quick glance for your PR. LGTM! I also noticed that you
refactor some anonymous implemention of Watcher to lambda style. Is that
related to this issue?
Further more, if u want this to be reviewed and finally merged, I think u
should mark this Jira PR available to attract attentions of other ones
> Replace dummy watcher with a unified singleton
> ----------------------------------------------
>
> Key: ZOOKEEPER-3523
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3523
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server, tests
> Affects Versions: 3.6.0
> Reporter: TisonKun
> Assignee: TisonKun
> Priority: Major
> Fix For: 3.6.0
>
>
> Currently we have many anonymous subclasses of {{Watch}} all of which is just
> event -> { }. We can reduce many subclasses in inherit tree by add a
> {{DUMMY_WATCHER}} in {{Watcher}} interface and replace all of those usages.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
