[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965422#comment-16965422
 ] 

Brian Nixon commented on ZOOKEEPER-3595:
----------------------------------------

Looks like this parameter got lost with "ZOOKEEPER-3179: Add snapshot 
compression to reduce the disk IO" 
[https://github.com/apache/zookeeper/pull/690.] It should be easy to restore by 
plumbing the argument through SnapStream.

A good first diff for anyone who wants an easy contribution.

> Fsync parameter for serialize method is ingnored
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-3595
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3595
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Jingguo Yao
>            Priority: Minor
>
> [ZOOKEEPER-2872: Interrupted snapshot sync causes data 
> loss|https://github.com/apache/zookeeper/commit/0706b40afad079f19fe9f76c99bbb7ec69780dbd]
>  introduced fsync parameter for serialize method. But this parameter is 
> ignored in  
> [FileSnap.java|https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileSnap.java#L232].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to