[
https://issues.apache.org/jira/browse/ZOOKEEPER-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983274#comment-16983274
]
Damien Diederen commented on ZOOKEEPER-3599:
--------------------------------------------
ZOOKEEPER-2122 added SSL support to the C client and to the {{cli_st}}/{{mt}}
tools. It introduced (much-welcome!) GNU-style {{getopt_long}} argument
parsing, but did not try to preserve backwards compatibility.
An earlier version of [PR #1131|https://github.com/apache/zookeeper/pull/1131]
introduced (optional) POSIX-style {{getopt}} argument parsing, and was
consequently largely obsoleted by the SSL update. It did, however, support
"old-style" arguments to avoid breaking workflows.
The updaded [PR #1131|https://github.com/apache/zookeeper/pull/1131] salvages
that feature while preserving the {{getopt_long}} goodness. It is
"legacy-only"; adding new positional arguments is not supported—as discussed in
this thread: #1131 (review).
The latest PR failed to build because one of the Jenkins workers was did not
have the "standard" OpenSSL configuration: [see discussion on
PR#1107|https://github.com/apache/zookeeper/pull/1107#issuecomment-557399890];
This should be fixed by ZOOKEEPER-3630.
> Use 'getopt', if available, in 'cli.c' shell
> --------------------------------------------
>
> Key: ZOOKEEPER-3599
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3599
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Damien Diederen
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Patches adding functionality to the C client library often want to make these
> new capabilities available/explorable via the {{cli.c}} shell.
> Examples include ZOOKEEPER-1112 (SASL; the original patchset included a
> duplicated {{cli_sasl.c}}) and ZOOKEEPER-2122 (SSL; the current PR switches
> it to use {{getopt}}).
> This ticket is about adding /optional/ {{getopt}} support to {{cli.c}}
> without breaking existing uses, and would be a prerequisite for extensions
> which "require" new flags.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
