[
https://issues.apache.org/jira/browse/ZOOKEEPER-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997266#comment-16997266
]
Hadoop QA commented on ZOOKEEPER-3539:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4299//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4299//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4299//console
This message is automatically generated.
> Fix branch-3.5 after upgrade on ASF CI
> --------------------------------------
>
> Key: ZOOKEEPER-3539
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3539
> Project: ZooKeeper
> Issue Type: Task
> Components: build, build-infrastructure
> Affects Versions: 3.5.5
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 3.5.6
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> ASF CI now lacks "findbugs" tool.
> ASF CI upgraded gcc and now there are some errors related to the usage of
> NULL in calls of fprintf.
> We should:
> - disable findbugs on CI ant-based tasks
> - use LOG_DEBUG consistently with the rest of code in C client
> Please note that on branch-3.5 we are officially using Maven and Spotbugs,
> ant stuff is there only for compatibility in build, findbugs is not strictly
> needed to check the goodness of code in branch-3.5.
> branch-3.4 is only with ANT, let's treat this problem as a different task
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
