[
https://issues.apache.org/jira/browse/ZOOKEEPER-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Mollitor updated ZOOKEEPER-3675:
--------------------------------------
Description:
* To be proper, minCommittedLog/maxCommittedLog should only be modified in a
lock.
* maxCommittedLog is potentially set twice (to the same value) for each call
to the method
* Streamline code in addCommittedProposal
* Pre-initialize committedLog data structure to the full size
* Remove unused commitLogBuffer
* Remove synchronization of method getCommittedLog(), it is protected with lock
* Unify grabbing locks outside of try block
* Fix off-by-one error in the size of the buffer
was:
* To be proper, minCommittedLog/maxCommittedLog should only be modified in a
lock.
* maxCommittedLog is potentially set twice (to the same value) for each call
to the method
* Streamline code in addCommittedProposal
* Pre-initialize committedLog data structure to the full size
* Remove unused commitLogBuffer
* Remove synchronization of method getCommittedLog(), it is protected with lock
* Unify grabbing locks outside of try block
> Clean Up committedLog Interaction in ZKDatabase
> -----------------------------------------------
>
> Key: ZOOKEEPER-3675
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3675
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> * To be proper, minCommittedLog/maxCommittedLog should only be modified in a
> lock.
> * maxCommittedLog is potentially set twice (to the same value) for each call
> to the method
> * Streamline code in addCommittedProposal
> * Pre-initialize committedLog data structure to the full size
> * Remove unused commitLogBuffer
> * Remove synchronization of method getCommittedLog(), it is protected with
> lock
> * Unify grabbing locks outside of try block
> * Fix off-by-one error in the size of the buffer
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
