[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013594#comment-17013594
 ] 

Enrico Olivelli commented on ZOOKEEPER-3695:
--------------------------------------------

It happens (this is not luck, it is intended) that the maven-sources-plugin 
generates a perfect snapshot of the repository

https://repository.apache.org/content/repositories/orgapachezookeeper-1045/org/apache/zookeeper/parent/3.6.0/
check the fix parent-3.6.0-source-release.zip

You can find the zip file inside target/checkout/target after running mvn 
release:perform 
- parent-3.6.0-source-release.zip
- parent-3.6.0-source-release.zip.asc
- parent-3.6.0-source-release.zip.sha512

This is exactly the 'maven way', it is Maven itself that it is creating the 
package.
I should add also that with the latest versions of Maven (3.6.3) and the latest 
version (22) of the Apache Maven Parent pom it is possible to achieve 
'reproducible builds' just by following the default configuration.

If it is fine to change the format of the "source release" from tar.gz to zip 
then the work is already done, we should only drop the assembly configuration 
that is trying to mimic the maven-sources-plugin but it is very tricky, in fact 
currently we are seeing the problems reported in the description of this issue.

 


> Source release tarball does not match repository in 3.6.0
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-3695
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3695
>             Project: ZooKeeper
>          Issue Type: Task
>          Components: build
>    Affects Versions: 3.6.0
>            Reporter: Enrico Olivelli
>            Assignee: Enrico Olivelli
>            Priority: Blocker
>             Fix For: 3.6.0
>
>
> During the release of 3.6.0, rc0, I noticed that the source tarball differs 
> from the repository:
> - there is no "dev/docker" directory (so we are missing a part of the 
> codebase, even this is not so important)
> - there is no "zookeeper-metrics-providers" directory (so the project is not 
> buildable)
> - the c client directory contains temporary files (so we are including 
> 'binaries')
> I have also noted that NOTICE file report 2019 and it should be 2020



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to