[
https://issues.apache.org/jira/browse/ZOOKEEPER-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046792#comment-17046792
]
Damien Diederen commented on ZOOKEEPER-3741:
--------------------------------------------
I just double-checked; the only thing which was applicable to {{3.6}} and
{{master}} was the one-liner which you backported. I'm getting clean compiles
now (GCC 8.3.0 with extra hardening).
Cheers, -D
> Fix ZooKeeper 3.5 C client build on Fedora8
> -------------------------------------------
>
> Key: ZOOKEEPER-3741
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3741
> Project: ZooKeeper
> Issue Type: Improvement
> Components: c client
> Affects Versions: 3.6.0
> Reporter: Mate Szalay-Beko
> Assignee: Mate Szalay-Beko
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.7.0, 3.6.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Using new RHEL / Centos8 docker images, it was not possible to build the
> ZooKeeper C client for 3.5.5 and 3.5.6. The compilation error was fixed by
> [~ztzg] in ZOOKEEPER-3719 for branch 3.5 and 3.5.7. But one of the errors is
> still present on the master branch.
> We had a warning that we are trying to call like
> {{sprintf(buf,"%s:%d",addrstr,port);}}, and both {{buf}} and {{addrstr}} are
> 128 long char arrays. So in theory, we can overflow. The fix is to increase
> the length of the destination string array ({{buf}}).
> Actually this problem only causing compile time warning / failure only on the
> 3.5.5 and 3.5.6. On 3.5.7 this was fixed and on 3.6+ branches the compiler
> can not detect the problem due to some code refactoring made by
> ZOOKEEPER-3068, but the issue is still present on the master branch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
