[
https://issues.apache.org/jira/browse/ZOOKEEPER-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051946#comment-17051946
]
Jono Morris edited comment on ZOOKEEPER-3735 at 3/5/20, 9:48 AM:
-----------------------------------------------------------------
The FileSnap snapshot deserialize method was changed during a pull request for
ZOOKEEPER 3512 so that the 'if' block calling 'deserializeZxidDigest' on the
data-tree (FileSnap ~ line 98) sets the data-tree '*digestFromLoadedSnapshot*'
attribute to 'null' if the start zsid is larger that the digest zxid in the
snapshot.
{code:java}
if (dt.deserializeZxidDigest(ia, snapZxid)) { ... {code}
Further down in FileSnap deserialize, the 'if' block skips the
'compareShapshotDigest' method (where the rate-logger call is made) when
'*digestFromLoadedSnapshot*' is null (FileSnap ~ line 116).
{code:java}
if (dt.getDigestFromLoadedSnapshot() != null) {
dt.compareSnapshotDigests(dt.lastProcessedZxid);
} {code}
was (Author: [email protected]):
The FileSnap snapshot deserialize method was changed during a pull request for
ZOOKEEPER 3512 so that the 'if' block calling 'deserializeZxidDigest' on the
data-tree (FileSnap ~ line 98) sets the data-tree '*digestFromLoadedSnapshot*'
attribute to 'null' if the start zsid is larger that the digest zxid in the
snapshot.
{code:java}
if (dt.deserializeZxidDigest(ia, snapZxid)) { ... {code}
Further down in FileSnap deserialize, the 'if' block skips the
'compareShapshotDigest' method (where the rate-logger call is made) when
'digestFromLoadedSnapshot' is null (FileSnap ~ line 116).
{code:java}
if (dt.getDigestFromLoadedSnapshot() != null) {
dt.compareSnapshotDigests(dt.lastProcessedZxid);
} {code}
> fix the bad format of RATE_LOGGER
> ---------------------------------
>
> Key: ZOOKEEPER-3735
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3735
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: maoling
> Priority: Minor
>
> {code:java}
> } else if (digestFromLoadedSnapshot.zxid != 0 && zxid >
> digestFromLoadedSnapshot.zxid) {
> RATE_LOGGER.rateLimitLog("The txn 0x{} of snapshot digest does not "
> + "exist.", Long.toHexString(digestFromLoadedSnapshot.zxid));
> }
> {code}
> the printed log likes this:
> {code:java}
> Message:The txn 0x{} of snapshot digest does not exist. Value:fa4e00000082
> {code}
> *1. 0x{}* takes no effort
> *2. RATE_LOGGER.rateLimitLog* doesn't use like the ordinary LOG
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
