[
https://issues.apache.org/jira/browse/ZOOKEEPER-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066108#comment-17066108
]
Brittany Barnes commented on ZOOKEEPER-3728:
--------------------------------------------
Hi,
Is this item in the correct state to be merged in? I've was looking over the
How to Contribute again and it says that a committer should mark the item as
Reviewed once done in GitHub (done) - however I marked it as Reviewed when I
changed the status to 'Patch Available'. I've removed that flag, but a little
confused on the Jira etiquette and want to confirm I have it in the appropriate
state.
Thank you in advance. Hoping to understand the flow before I help with
additional items.
> move traceMask calculation logic into the trace log in the
> FinalRequestProcessor#processRequest
> -----------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3728
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3728
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: maoling
> Assignee: Brittany Barnes
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> LOG.debug("Processing request:: {}", request);
> // request.addRQRec(">final");
> long traceMask = ZooTrace.CLIENT_REQUEST_TRACE_MASK;
> if (request.type == OpCode.ping) {
> traceMask = ZooTrace.SERVER_PING_TRACE_MASK;
> }
> if (LOG.isTraceEnabled()) {
> ZooTrace.logRequest(LOG, traceMask, 'E', request, "");
> }
> {code}
> # remove the useless *// request.addRQRec(">final");*
> # most read/write requests will hit the code here but useless when Log
> Trace disable. we need to move traceMask calculation logic into the
> LOG.isTraceEnabled()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
