[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zili Chen updated ZOOKEEPER-3782:
---------------------------------
    Description: 
After Py3, {{filter}} return a {{filter object}} instead of {{list object}}, 
which causes

Traceback (most recent call last):
  File "zk-merge-pr.py", line 533, in <module>
    main()
  File "zk-merge-pr.py", line 519, in main
    resolve_jira_issues(commit_title, merged_refs, jira_comment)
  File "zk-merge-pr.py", line 329, in resolve_jira_issues
    resolve_jira_issue(merge_branches, comment, jira_id)
  File "zk-merge-pr.py", line 312, in resolve_jira_issue
    jira_fix_versions = [get_version_json(v) for v in fix_versions]
  File "zk-merge-pr.py", line 312, in <listcomp>
    jira_fix_versions = [get_version_json(v) for v in fix_versions]
  File "zk-merge-pr.py", line 310, in get_version_json
    return filter(lambda v: v.name == version_str, versions)[0].raw
TypeError: 'filter' object is not subscriptable

We can replace filter with list comprehension to fix it.

  was:
After Py3, {{filter}} return a {{filter object}} instead of {{list object}}, 
which causes

TypeError: 'filter' object is not subscriptable

We can replace filter with list comprehension to fix it.


> Replace filter with list comprehension for returning list in zk-merge-pr.py
> ---------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-3782
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3782
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Zili Chen
>            Assignee: Zili Chen
>            Priority: Major
>
> After Py3, {{filter}} return a {{filter object}} instead of {{list object}}, 
> which causes
> Traceback (most recent call last):
>   File "zk-merge-pr.py", line 533, in <module>
>     main()
>   File "zk-merge-pr.py", line 519, in main
>     resolve_jira_issues(commit_title, merged_refs, jira_comment)
>   File "zk-merge-pr.py", line 329, in resolve_jira_issues
>     resolve_jira_issue(merge_branches, comment, jira_id)
>   File "zk-merge-pr.py", line 312, in resolve_jira_issue
>     jira_fix_versions = [get_version_json(v) for v in fix_versions]
>   File "zk-merge-pr.py", line 312, in <listcomp>
>     jira_fix_versions = [get_version_json(v) for v in fix_versions]
>   File "zk-merge-pr.py", line 310, in get_version_json
>     return filter(lambda v: v.name == version_str, versions)[0].raw
> TypeError: 'filter' object is not subscriptable
> We can replace filter with list comprehension to fix it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to