[
https://issues.apache.org/jira/browse/ZOOKEEPER-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077547#comment-17077547
]
Hadoop QA commented on ZOOKEEPER-3780:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4396//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4396//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4396//console
This message is automatically generated.
> restore Version.getRevision() to be backward compatible
> -------------------------------------------------------
>
> Key: ZOOKEEPER-3780
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3780
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.6.0, 3.5.6, 3.5.7
> Reporter: Norbert Kalmár
> Assignee: Norbert Kalmár
> Priority: Critical
> Labels: pull-request-available
> Fix For: 3.7.0, 3.6.1, 3.5.8
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> We removed the getRevision() function in 3.5.6:
> https://github.com/apache/zookeeper/commit/96880c0b2ba39f1841f8bdc4a0119a467b462d03#diff-1d42dde48d42e3baf819e22b56a880a7
> Some projects (like HBase for example) are actually using this method.
> (Although not relevant anymore, since we are on git).
> 3.5.6, 3.5.7 and 3.6.0 does not have this method anymore. However, if someone
> is using this function, to make upgrading easier, we should restore it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
