[
https://issues.apache.org/jira/browse/ZOOKEEPER-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201795#comment-17201795
]
Xiaotian Qi edited comment on ZOOKEEPER-3944 at 9/25/20, 1:09 AM:
------------------------------------------------------------------
Hi Damien,
I actually prefer free it in zookeeper_close, as in the destroy method it [set
a state of the sasl client
struct|https://github.com/apache/zookeeper/blob/master/zookeeper-client/zookeeper-client-c/src/zk_sasl.c#L118].
This looks to me like semantically destroy should not free the
memory(otherwise setting the state is useless)
was (Author: xiaotian_qi):
Hi Damien,
I actually prefer free it in zookeeper_close, as in the destroy method it set a
state of the sasl client struct. This looks to me like semantically destroy
should not free the memory(otherwise setting the state is useless)
Xiaotian
发自我的iPhone
> zookeeper c api sasl client memory leak
> ---------------------------------------
>
> Key: ZOOKEEPER-3944
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3944
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.6.2
> Reporter: Xiaotian Qi
> Priority: Major
> Attachments: 0001-ZOOKEEPER-3944-Fix-sasl-memory-leak.patch
>
>
> I find this memory leak through sanitizer.
> [Here|https://github.com/apache/zookeeper/blob/master/zookeeper-client/zookeeper-client-c/src/zookeeper.c#L664-L665]
> within zookeeper_close() it destroy the client and reset it to NULL. This
> client is created using calloc()
> In zoo_sasl_client_destroy(), the client is not freed, neither within
> zookeeper_close().
> I would suggest add a free() before setting it to NULL in zookeeper_close
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
