[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201945#comment-17201945
 ] 

Enrico Olivelli commented on ZOOKEEPER-3944:
--------------------------------------------

[~xiaotian_qi] please send a Pull request, now we have all workflows integrated 
with github.

With a PR a CI job will validate the patch automatically for instance

> zookeeper c api sasl client memory leak
> ---------------------------------------
>
>                 Key: ZOOKEEPER-3944
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3944
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.6.2
>            Reporter: Xiaotian Qi
>            Priority: Major
>         Attachments: 0001-ZOOKEEPER-3944-Fix-sasl-memory-leak.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> I find this memory leak through sanitizer.
> [Here|https://github.com/apache/zookeeper/blob/master/zookeeper-client/zookeeper-client-c/src/zookeeper.c#L664-L665]
>  within zookeeper_close() it destroy the client and reset it to NULL. This 
> client is created using calloc()
> In zoo_sasl_client_destroy(), the client is not freed, neither within 
> zookeeper_close(). 
> I would suggest add a free() before setting it to NULL in zookeeper_close



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to