[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Damien Diederen resolved ZOOKEEPER-4219.
----------------------------------------
    Resolution: Fixed

> Quota checks break setData in multi transactions
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-4219
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4219
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.7.0, 3.8.0
>            Reporter: Damien Diederen
>            Assignee: Damien Diederen
>            Priority: Blocker
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> On a server with {{enforceQuota=true}}, {{multi()}} transactions containing 
> {{setData}} operations can throw {{NullPointerException}} during the quota 
> check.
> On the server side, this looks like:
> {code:java}
> java.lang.NullPointerException
>     at 
> org.apache.zookeeper.server.ZooKeeperServer.checkQuota(ZooKeeperServer.java:2048)
>     at 
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:397)
>         [...]
> {code}
> On the client side, this is reflected as a {{MarshallingError}}:
> {code:java}
> org.apache.zookeeper.KeeperException$MarshallingErrorException: 
> KeeperErrorCode = MarshallingError
>     at org.apache.zookeeper.KeeperException.create(KeeperException.java:104)
>     at org.apache.zookeeper.ZooKeeper.multiInternal(ZooKeeper.java:1758)
>         [...]
> {code}
> This is visibly due to the quota check trying to access node data by path 
> from the {{PrepRequestProcessor}} without considering the collection of 
> {{outstandingChanges}}.  I have a patch in the works.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to