[
https://issues.apache.org/jira/browse/ZOOKEEPER-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ling Mao resolved ZOOKEEPER-3231.
---------------------------------
Fix Version/s: 3.7.0
Resolution: Fixed
> Purge task may lost data when the recent snapshots are all invalid
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-3231
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3231
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.4, 3.4.13
> Reporter: Jiafu Jiang
> Assignee: Ling Mao
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.7.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> I read the ZooKeeper source code, and I find the purge task use
> FileTxnSnapLog#findNRecentSnapshots to find snapshots, but the method does
> not check whether the snapshots are valid.
> Consider a worse case, a ZooKeeper server may have many invalid snapshots,
> and when a purge task begins, it will use the zxid in the last snapshot's
> name to purge old snapshots and transaction logs, then we may lost data.
> I think we should use FileSnap#findNValidSnapshots(int) instead of
> FileSnap#findNRecentSnapshots in FileTxnSnapLog#findNRecentSnapshots, but I
> am not sure.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
