[
https://issues.apache.org/jira/browse/ZOOKEEPER-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-4605:
--------------------------------------
Labels: pull-request-available (was: )
> When deciding whether to send more notifications, no check is made that all
> queues are empty
> --------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-4605
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4605
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: nagi kami
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current implementation only checks that one queue is empty and not all
> queues are empty.
> {code:java}
> boolean haveDelivered() {
> for (BlockingQueue<ByteBuffer> queue : queueSendMap.values()) {
> final int queueSize = queue.size();
> LOG.debug("Queue size: {}", queueSize);
> if (queueSize == 0) {
> return true;
> }
> }
> return false;
> } {code}
> Perhaps it could be:
> {code:java}
> boolean haveDelivered() {
> for (BlockingQueue<ByteBuffer> queue : queueSendMap.values()) {
> final int queueSize = queue.size();
> LOG.debug("Queue size: {}", queueSize);
> if (queueSize != 0) {
> return false;
> }
> }
> return true;
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
