[
https://issues.apache.org/jira/browse/ZOOKEEPER-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083193#comment-18083193
]
David Smiley commented on ZOOKEEPER-4324:
-----------------------------------------
Wow! It's surprising to encounter this problem in Solr since we took no step
to exclude it from our ZooKeeper dependency transitively. "provided" scope is
definitely inappropriate. Seems the intention was effectively "optional"...
albeit it isn't even actually optional.
> Hard dependency on io.dropwizard.metrics:metrics-core cannot be avoided
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-4324
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4324
> Project: ZooKeeper
> Issue Type: Bug
> Components: metric system
> Affects Versions: 3.6.3
> Reporter: Ron Dagostino
> Priority: Major
>
> The metrics subsystem has a hard dependency on
> io.dropwizard.metrics:metrics-core that cannot be avoided because of this
> code:
> public final class ServerMetrics {
> /**
> * Dummy instance useful for tests.
> */
> public static final ServerMetrics DEFAULT_METRICS_FOR_TESTS = new
> ServerMetrics(new DefaultMetricsProvider());
> Even if the config
> metricsProvider.className=org.apache.zookeeper.metrics.impl.NullMetricsProvider
> is set the above code will still execute and create the dependency.
> It would be best to make the dependency optional by removing the above code.
> Another option is to change the dependency scope from the current value of
> "provided" to be "compile" instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
