On Mon, Jul 13, 2009 at 01:35:09PM +0200, Antoine Reilles wrote:
> > > The attached patch does fix this segfault, and dit let isync work again
> > > for me.
> > > 

> -     bl = nfsnprintf( base, sizeof(base), "%ld.%d_%d.%s", time( 0 ), Pid, 
> ++MaildirCount, Hostname );
> +     bl = nfsnprintf( base, sizeof(base), "%lld.%d_%d.%s", (long long int) 
> time( 0 ), Pid, ++MaildirCount, Hostname );
>
hmpf. choosing an upcast is "wasteful" and fairly useless for the next
almost 30 years. on a more serious note, %lld is not necessarily
portable (C99 syntax, i think). i think the simple route of downcasting
to long is good enough for now. if you like overkill, you could adjust
the format string depending on the system (i do such magic for file
offsets in puf.sf.net).

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
isync-devel mailing list
isync-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/isync-devel

Reply via email to