On Mon, Dec 31, 2012 at 02:17:38PM +0100, Nikola Pajkovsky wrote:
> this change makes code more readable
>
that's subjective.
i'd consider either variant if this was new code, but i'm not going to
make such changes to existing code, unless the structure changes as a
precondition of a "real" change.
> old 'if'
>
> if (is_atom( tmp )) {
> ....
> }
>
> was inverted to
>
> if (!is_atom(tmp))
> continue;
>
> and code is now correctly indented.
>
well, in fact, you broke the indentation, as far as i'm concerned. ;)
i'm quite a coding style nazi, so you can be relatively sure that
everything you see looks *exactly* the way i want it to look like. only
inconsistencies between semantically identical constructs indicate
genuine mistakes (i admit that i made some ^^).
i'm back in town now, so you can catch me on irc (ossi@freenode) if you
have questions.
looking forward to more (substantial ;) contributions from you. :)
------------------------------------------------------------------------------
Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
much more. Get web development skills now with LearnDevNow -
350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122812
_______________________________________________
isync-devel mailing list
isync-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/isync-devel
