commit 532d964aea327c4ff77fac5c3979c7d302f97d76
Author: Oswald Buddenhagen <[email protected]>
Date: Sat Apr 12 18:59:45 2014 +0200
error-check renaming of uid mapping database
for pedantry.
found by coverity.
src/compat/convert.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/compat/convert.c b/src/compat/convert.c
index 921335c..ba18da0 100644
--- a/src/compat/convert.c
+++ b/src/compat/convert.c
@@ -240,7 +240,10 @@ convert( config_t *box )
goto err4;
}
db->close( db, 0 );
- rename( iumname, diumname );
+ if (rename( iumname, diumname )) {
+ sys_error( "Cannot rename %s to %s", iumname, diumname
);
+ goto err4;
+ }
} else {
if (!(fp = fopen( uvname, "w" ))) {
sys_error( "Cannot create %s", uvname );
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
isync-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/isync-devel
