commit 3db3f4718e05751ef3541742552d33e7fc4a3937
Author: Oswald Buddenhagen <[email protected]>
Date:   Sun Oct 26 22:03:51 2014 +0100

    remove stray CRLF from AUTHENTICATE continuations
    
    this re-introduces 6741bc94 (just a bit differently), thus effectively
    reverting fbfcfea5. i suppose this extra CRLF is needed by a broken
    CRAM-MD5 implementation of some server, which is why it was there in the
    original implementation as well. however, it breaks more pedantic
    non-broken servers. if somebody complains, we'll need to add a much
    more sophisticated hack.

 src/drv_imap.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/drv_imap.c b/src/drv_imap.c
index 0cbe81c..21499c8 100644
--- a/src/drv_imap.c
+++ b/src/drv_imap.c
@@ -1270,7 +1270,8 @@ imap_socket_read( void *aux )
                                        ctx->trashnc = TrashKnown; /* Can't get 
NO [TRYCREATE] any more. */
                                p = cmdp->param.data;
                                cmdp->param.data = 0;
-                               if (socket_write( &ctx->conn, p, 
cmdp->param.data_len, GiveOwn ) < 0)
+                               if (socket_write( &ctx->conn, p, 
cmdp->param.data_len, GiveOwn ) < 0 ||
+                                   socket_write( &ctx->conn, "\r\n", 2, 
KeepOwn ) < 0)
                                        return;
                        } else if (cmdp->param.cont) {
                                if (cmdp->param.cont( ctx, cmdp, cmd ))
@@ -1279,8 +1280,6 @@ imap_socket_read( void *aux )
                                error( "IMAP error: unexpected command 
continuation request\n" );
                                break;
                        }
-                       if (socket_write( &ctx->conn, "\r\n", 2, KeepOwn ) < 0)
-                               return;
                } else {
                        tag = atoi( arg );
                        for (pcmdp = &ctx->in_progress; (cmdp = *pcmdp); pcmdp 
= &cmdp->next)

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
isync-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/isync-devel

Reply via email to