commit 1e939bafd88fba862db538176520e4c88bebe424
Author: Oswald Buddenhagen <[email protected]>
Date: Sun Apr 2 12:03:16 2017 +0200
don't use strncpy() to copy TUIDs
latest since 77acc268, the code prior to these statements ensures that
the full length is available, so just use memcpy(). the code for
comparing TUIDs uses memcmp() anyway.
src/drv_imap.c | 2 +-
src/drv_maildir.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/drv_imap.c b/src/drv_imap.c
index e89cea2..6d247b0 100644
--- a/src/drv_imap.c
+++ b/src/drv_imap.c
@@ -1060,7 +1060,7 @@ parse_fetch_rsp( imap_store_t *ctx, list_t *list, char *s
ATTR_UNUSED )
cur->gen.srec = 0;
cur->gen.msgid = msgid;
if (tuid)
- strncpy( cur->gen.tuid, tuid, TUIDL );
+ memcpy( cur->gen.tuid, tuid, TUIDL );
else
cur->gen.tuid[0] = 0;
if (ctx->gen.uidnext <= uid) /* in case the server sends no
UIDNEXT */
diff --git a/src/drv_maildir.c b/src/drv_maildir.c
index d174bdd..97a63c7 100644
--- a/src/drv_maildir.c
+++ b/src/drv_maildir.c
@@ -1132,7 +1132,7 @@ maildir_init_msg( maildir_store_t *ctx, maildir_message_t
*msg, msg_t *entry )
entry->msgid = 0; /* prevent deletion */
msg->gen.size = entry->size;
msg->gen.srec = 0;
- strncpy( msg->gen.tuid, entry->tuid, TUIDL );
+ memcpy( msg->gen.tuid, entry->tuid, TUIDL );
if (entry->recent)
msg->gen.status |= M_RECENT;
if (ctx->gen.opts & OPEN_FLAGS) {
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
isync-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/isync-devel
