On Fri, Feb 23, 2018 at 04:26:17PM +0100, Michael J Gruber wrote: > maildir supports a 'P' flag which denotes the fact that a message has > been 'passed' on (forwarded, bounced). notmuch syncs this to the > 'passed' tag. > interesting.
> And sure enough, there was yet another flag bit definition in > src/driver.h... Found out the hard way. (This is the the only change in > v2 compared to v1.) > it would make sense to add comments cross-referencing the instances in the same go. > diff --git a/src/drv_imap.c b/src/drv_imap.c > @@ -986,18 +987,20 @@ parse_fetch_rsp( imap_store_t *ctx, list_t *list, char > *s ATTR_UNUSED ) > - if > (flags->val[1] == 'X' && flags->val[2] == '-') > + if > (flags->val[0] == '\\' && flags->val[1] == 'X' && flags->val[2] == '-') > goto > flagok; /* ignore system flag extensions */ > + if > (flags->val[0] == '$') > + goto > flagok; /* ignore unknown user-defined flags (keywords) */ > i'd move that above the previous case, to keep the system ones closer together. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ isync-devel mailing list isync-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/isync-devel
