[commit] master: don't unnecessarily re-initialize some members of imap_store

[Oswald Buddenhagen via isync-devel]

commit c83330ffe8af72b3dea381c0e43562d572d0ad85
Author: Oswald Buddenhagen <o...@users.sf.net>
Date:   Tue Aug 4 09:06:41 2020 +0200

    don't unnecessarily re-initialize some members of imap_store
    
    ... when recycling server connections.

 src/drv_imap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/drv_imap.c b/src/drv_imap.c
index 9103e8a..75b44cd 100644
--- a/src/drv_imap.c
+++ b/src/drv_imap.c
@@ -1824,6 +1824,8 @@ imap_alloc_store( store_conf_t *conf, const char *label )
 
        /* Finally, schedule opening a new server connection. */
        ctx = nfcalloc( sizeof(*ctx) );
+       ctx->gen.driver = &imap_driver;
+       ctx->ref_count = 1;
        socket_init( &ctx->conn, &srvc->sconf,
                     (void (*)( void * ))imap_invoke_bad_callback,
                     imap_socket_read, (void (*)(void *))flush_imap_cmds, ctx );
@@ -1832,10 +1834,8 @@ imap_alloc_store( store_conf_t *conf, const char *label )
        ctx->wait_check_append = &ctx->wait_check;
 
   gotsrv:
-       ctx->gen.driver = &imap_driver;
        ctx->gen.conf = conf;
        ctx->label = label;
-       ctx->ref_count = 1;
        return &ctx->gen;
 }
 


_______________________________________________
isync-devel mailing list
isync-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/isync-devel