On Sat, Sep 28, 2024 at 09:23:49AM +0000, Behnam Lal Moghaddam wrote:
I want to share a patch that allows mbsync-get-cert script to support STARTTLS and custom port.
thanks! a few suggestions: - use true/false for $STARTTLS - then you can evaluate it without running it through `test` - don't default the port - then you can make it fall back depending on $STARTTLS, which would make specifying a port generally unnecessary - a signed-off-by footer is optional here, but make sure that the author info is sane and matches S-O-B if present i'm pondering whether i should classify this omission as a bug and therefore apply this for 1.5.1. strictly speaking, it's a feature, so material for master ... _______________________________________________ isync-devel mailing list isync-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/isync-devel
