On Sat, Nov 30, 2024 at 11:55:33AM +0100, Oswald Buddenhagen via isync-devel
wrote:
> On Fri, Nov 29, 2024 at 06:21:45PM -0500, Paymon MARANDI wrote:
> > any feedback?
> >
> yeah, sorry, i've been procrastinating and then it went out of view ...
>
> i don't like it, because it makes the version info useless, which would
> make worse log files. adding --always to the describe command seems less
> disruptive.
oh, didn't know about that one.
> the use case also feels a bit silly - given that the worktree is over
> half a meg and the build tree several times that much, shrinking the
> pack from just 2 megs to 200k seems mostly pointless.
i updated the log, hopefully will add proper justification.
--
Paymon
>From 4885752d0b8b56da90b609e10891aeaa363b51ad Mon Sep 17 00:00:00 2001
From: Paymon <darwinsker...@gmail.com>
Date: Tue, 3 Dec 2024 15:25:09 -0500
Subject: [PATCH] build: also consider builds off of git with `git clone
--depth 1`
one case this could happen is a shallow clone, purely for build
purposes. in source based distros, like gentoo, setting depth of the
clone to 1, globally, is a common configuration. this will avoid those
builds to fail.
Signed-off-by: Paymon MARANDI <darwinsker...@gmail.com>
---
version.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/version.sh b/version.sh
index fc1ed7d..5dfc61b 100755
--- a/version.sh
+++ b/version.sh
@@ -22,7 +22,7 @@ else
# find out whether we have local work, and if so, collapse it into
# a single suffix. otherwise, we'd cause pointless rebuilds during
# development.
- gver=$(git describe --tags $mb)
+ gver=$(git describe --always --tags $mb)
lcl=$(git rev-list -n 1 $mb..HEAD)
if test -n "$lcl"; then
gver="$gver-plus"
--
2.47.1
_______________________________________________
isync-devel mailing list
isync-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/isync-devel
