Hello! This patch set includes the revised IMAP auth interface as well as initial support for GNU SASL. Changes from v1 include moving the separation of SASL/non-SASL logic from separate files to between preprocessor guards, simplifying the mechanism filtering logic, and making imap_auth_client_t non-opaque.
The added implementation with GNU SASL attempts to provide effectively the same functionality as the implementation with Cyrus SASL. For example, GNU SASL gives more control over choosing which SASL mechanism to use, so the patch uses a whitelist of mechanisms corresponding to those able to be used with Cyrus SASL (accounting for the information currently provided to the library). Support for more mechanisms can be later added for both implementations. Note that this was my first time really working with autoconf, so while I tried my best to check my modifiations to configure.ac were correct, it is still very possible I made a mistake. Feel free to scrutinise the patch for any such findings. Seth McDonald (2): Add unified IMAP authentication interface Add support for GNU SASL configure.ac | 56 +++- src/Makefile.am | 2 + src/common.h | 3 + src/drv_imap.c | 322 ++++------------------ src/imap_auth.c | 697 ++++++++++++++++++++++++++++++++++++++++++++++++ src/imap_auth.h | 107 ++++++++ src/main.c | 4 +- src/util.c | 34 +++ 8 files changed, 953 insertions(+), 272 deletions(-) create mode 100644 src/imap_auth.c create mode 100644 src/imap_auth.h base-commit: 7cbbc65be29508f3c71fd83715d40a9aab0033ab -- 2.47.3 _______________________________________________ isync-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/isync-devel
