Hello,
I am trying to understand IText source code.
(Thanks to all developers for their efforts!).

Is this the right place and method to contribute some remarks?

a) dead code ; lines of code who seem to do nothing

source:
itext-src-1.1.tar.gz
 com.lowagie.text.pdf.PdfPRow.java
  method: public float calculateHeights()
  {
    ...
    ...
    //next line local variable 'table' is not used in this method.
    // why asking for it?
    PdfPTable table = cell.getTable();
    ...
  }

b) names of variables too general to facilitate easy search

source:
itext-src-1.1.tar.gz
 com.lowagie.text.pdf.PdfWriter.java
  ....
  //as this source contains 'pdf' many times, it is hard to search
  // for this member variable 'pdf' only
  // why not give it a more difficult name like pdfdcmnt ?
  protected PdfDocument pdf;
  .....
  
c) 
source:
itext-src-1.1.tar.gz
 compile.xml

  why not add property 'listfiles="yes"' to target 'compile.debug' ?
  So one can check each time which files are recompiled.


Thanks and heartily greetings

Herman Vierendeels
[EMAIL PROTECTED]

___________________________________________________
Build your own website, it's easy and fun.

http://www.homemaster.net - Homemaster. Come Together. Online.



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
iText-questions mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/itext-questions

Reply via email to