Daniel Essin wrote: > That's a very helpful summary. As far as not mentioning it, that's fine > as far as the text is concerned, but it probably should be included on > the class diagram of the PdfWriter since that's highly technical and > should really correspond to the visible properties and methods of the > classes.
You have a point there. We had serious discussions about those class diagrams. There was no way to make complete diagrams: they just wouldn't fit on one or two pages. I think I suggested that it only made sense to add the diagrams if the book was accompanied by a poster in a bigger format, but that wasn't an option. I contacted some of the reviewers asking for their advice, and most of them said, they'd rather have diagrams with a limited list of methods, than no diagrams at all. In most cases they just wanted to see how the different classes relate to each other. Although I wasn't really convinced, I decided to take their advice, but I am thinking of doing some refactoring (for instance: in the next iText version, I'll move all the ViewerPreferences to a separate class) and make some more accurate class diagrams in PDF, so that iText developers can chose if and how they print the diagrams. As for the streams, you are right: there probably isn't a reason to keep the stream open, but somebody thought it made sense, so we provided the method. I'm still not sure if you're right about writing the stream to the output stream directly (without writing it to memory first). Granted, your approach is more elegant, and it works for most of the browsers, but if you're not developing for a controlled environment, I'm 99% sure the help desk will get calls from people that are not able to open the PDF because of browser issue. Keep that in mind while developing so that you can easily implement the workaround (if necessary). best regards, Bruno ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ iText-questions mailing list iText-questions@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/itext-questions Buy the iText book: http://itext.ugent.be/itext-in-action/
