Hi,
You're right. My mistake.

Best.
Ranier
________________________________________
De: Antonio Scuri <antonio.sc...@gmail.com>
Enviado: quarta-feira, 17 de janeiro de 2018 22:16
Para: IUP discussion list.
Assunto: Re: [Iup-users] CID 210623 (#1 of 1): Explicit null dereferenced 
(FORWARD_NULL)

  In that case the loop will be:

  while (capture != NULL)
      capture = capture->next_one;

  It is not necessarily an infinite loop.

Best,
Scuri


2018-01-17 19:48 GMT-02:00 Ranier VF 
<ranier_...@hotmail.com<mailto:ranier_...@hotmail.com>>:
Hi,
With fix in th SVN, the following may occur;
next is NULL.
If the first capture->type != IMASK_CAPT_OPEN, an infinite loop will occur.
Maybe switch to Do While loop?

Best.
Ranier.
________________________________________
De: Antonio Scuri <antonio.sc...@gmail.com<mailto:antonio.sc...@gmail.com>>
Enviado: quarta-feira, 17 de janeiro de 2018 21:04
Para: IUP discussion list.
Assunto: Re: [Iup-users] CID 210623 (#1 of 1): Explicit null dereferenced 
(FORWARD_NULL)

  Fixed and committed to SVN. I have no idea if that condition could occur...

Best,
Scuri

2018-01-16 23:29 GMT-02:00 Ranier VF 
<ranier_...@hotmail.com<mailto:ranier_...@hotmail.com><mailto:ranier_...@hotmail.com<mailto:ranier_...@hotmail.com>>>:
Hi,
Issue found by Coverity Scan.
CID 210623 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
9. var_deref_op: Dereferencing null pointer next.

File: iup_maskmatch.c
Function: iMaskMatchCaptureResult

code:
  next = NULL;

  while (capture != NULL)
  {
    if (capture->type == IMASK_CAPT_OPEN)
    {
      ImaskCapt *cap = capture->next_one;

      capture->next_one = next;
      next = capture;
      capture = cap;
    }
    else
    {
      if (capture->pos >= next->pos)
        (*vars->function)((char)capture->which_one, next->pos, capture->pos, 
vars->text, vars->user);

      next = next->next_one;
      capture = capture->next_one;
    }
  }

Need rethink this function, if capture->type != IMASK_CAPT_OPEN and
next is NULL,

Best.
Ranier.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Iup-users mailing list
Iup-users@lists.sourceforge.net<mailto:Iup-users@lists.sourceforge.net><mailto:Iup-users@lists.sourceforge.net<mailto:Iup-users@lists.sourceforge.net>>
https://lists.sourceforge.net/lists/listinfo/iup-users


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Iup-users mailing list
Iup-users@lists.sourceforge.net<mailto:Iup-users@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/iup-users


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Iup-users mailing list
Iup-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iup-users

Reply via email to