G'day all,

Congratulations to Antonio on releasing IUP 3.28.  I've been watching
the SVN repository closely for some time, and the activity in the
last few weeks has been very impressive!

I build IUP using various versions of GCC on different platforms,
and have noticed that it issues a warning regarding the new
iup_vled code that is potentially a weakness:

At line 2114, change:

        fprintf(file, comments);

to:

        fprintf(file, "%s", comments);

This change is expressed in the attached patch.

(At a wider scale, what if fprintf returns some sort of error signal,
e.g. -1 or some other negative value?  There is more than one place
where this issue occurs; this may warrant some clarification at some
stage.)

Any way cheers, and have a blessed Christmas (or substitute the
appropriate celebration day for your circumstances).

Me, I'll be sweating:
      Today:     42 deg C (107.6 F)
      Tomorrow:  42 deg C (107.6 F) (forecast)
      Thursday:  41 Deg C (105.8 F) (forecast)
      Friday:    44 deg C (111.2 F) (forecast)

sur-behoffski (Brenton Hoff)
programmer, Grouse Software
Index: srcvled/iup_vled.c
===================================================================
--- srcvled/iup_vled.c	(revision 5543)
+++ srcvled/iup_vled.c	(working copy)
@@ -2112,7 +2112,7 @@
     else
       comments = load_comments(src_filename);
 
-    fprintf(file, comments);
+    fprintf(file, "%s", comments);
 
     if (!multitext)
       free(comments);
_______________________________________________
Iup-users mailing list
Iup-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iup-users

Reply via email to