Hans Verkuil wrote:
This is due to r2954 changing the volume scaling in the msp3400.
I don't think this change is a good thing. Sure, you can crank up
the volume to the point it becomes clipped and overblown, but the
driver shouldn't rescale the volume range to keep you out of an area
where you /might/ encounter that condition.
This also doesn't jive with the volume rescale code I put in the
cx25840-audio unit, since both are based on quantizing the passed
volume to the range specified by the msp3400 datasheet, not the
arbitrary limit imposed by clipping 10% off the volume in the driver.
I've mailed the v4l list to see if this code from msp3400.c can be
removed. I agree, it doesn't belong there at all. Until the driver is
changed in v4l I keep it as it is now. The v4l driver and the one in
ivtv-0.4 should remain synchronized.
I agree about the sync between the v4l and our msp3400, since 0.5
uses the v4l version. Thanks for doing the legwork and checking with
them.
_______________________________________________
ivtv-devel mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
