On Saturday 20 October 2007 15:48:56 Duncan Webb wrote:
> Hans Verkuil wrote:
> > On Saturday 20 October 2007 11:31:27 Duncan Webb wrote:
> >> Hans Verkuil wrote:
> >>> On Friday 19 October 2007 21:52:15 Duncan Webb wrote:
> >>>> Hans Verkuil wrote:
> >>>>> On Friday 19 October 2007 19:30:59 Duncan Webb wrote:
> >>>>>> Hans Verkuil wrote:
> >>>
> >>> The old IVTV_IOC_S_GOP_END has been removed. Instead use the new
> >>> VIDIOC_ENCODER_CMD and VIDIOC_TRY_ENCODER_CMD ioctls if you want
> >>> this feature. See the v4l2 spec for more details.
> >>
> >> Still having a little bit of a problem with VIDIOC_ENCODER_CMD,
> >> does this need to be called just before the stream off command,
> >> replace it (as I think is correct) or as with IVTV_IOC_S_GOP_END
> >> before reading begins?
> >
> > It replaces STREAMOFF. STREAMOFF was always a half-baked
> > implementation at best and was replaced with this command. The
> > STREAMON/OFF command are really meant for the V4L2 stream I/O API.
> > Since ivtv doesn't support stream I/O the driver's VIDIOC_STREAMOFF
> > support was removed.
>
> Thanks you, much simpler.
>
> In v4l2-ctl.cpp there is one inconsistency, where the others use
> s.c_str() and V4L2_CTRL_TYPE_INTEGER64 uses queryctrl->name.
> printf("%31s (int64): value=%lld", queryctrl->name, ctrl->value64);
Thanks, I fixed that. There are no controls at the moment that use
INTEGER64, which is probably the reason this was never caught.
> Why does the API not have a type in the struct v4l2_ext_control, this
> seems a bit inconsistent with the rest of the API?
The type of a control has to be queried through VIDIOC_QUERYCTRL. That's
the way the control API works. The extended control API tries to
minimize the differences between the old and new control API and so it
reuses the VIDIOC_QUERYCTRL and VIDIOC_QUERYMENU ioctls, although these
were extended slightly. Also take a look at the qv4l2 that is part of
the v4l2-apps directory in the v4l-dvb repository at www.linuxtv.org:
this basically creates a control panel that the user can use to control
the MPEG and User controls. It's completely dynamic using only the
VIDIOC_QUERYCTRL/MENU information. It's really the way applications
should use it, although none do as far as I know.
Regards,
Hans
_______________________________________________
ivtv-devel mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
