>>> Signed-off-by: Michael Krufky <[EMAIL PROTECTED]> >> >> In this case, it should be reviewed-by. >> >> I should be sending this soon to Linus. > > > Mauro, > > I think it's wrong that you alter signatures. You did this: > > Reviewed-by: <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>
Argh! I didn't notice that weird stuff. This should be fixed before forwarding the patch. Sorry for the mess. > But I provided this: > > Signed-off-by: Michael Krufky <[EMAIL PROTECTED]> > > I sign the patch, because I have handled it in my -stable queue. SOB is the proper tag for your -stable queue. However, asking me to add this to my tree is not what it is expected. SOB is meant to track the patch history until it reaches the kernel. So, the first SOB(s) is(are) from its author(s). The author(s) will send this to a driver maintainer, that will send to a subsystem maintainer, etc, until reach mainstream. In the case of this patch, it was sent to the ML. Hans picked it, as the maintainer of ivtv, and asked me to pull. You didn't wrote the patch, not forwarded it to me, so, the tag doesn't apply on my tree. After the merge at mainstream, you'll send this to stable. In this case, you'll take it from my tree, add your SOB, and forward it. Unfortunately, it is a common mistake of people sending SOB's instead of acked-by or reviewed-by, so several maintainers warns about the improper usage of the tags and corrects it on their trees, or simply ignores such improper usage. If you prefer, I may just drop the tag from my tree, or fix the "reviewed-by". Cheers, Mauro. _______________________________________________ ivtv-devel mailing list [email protected] http://ivtvdriver.org/mailman/listinfo/ivtv-devel
