Andy Walls wrote: > On Mon, 2009-07-27 at 11:09 +0530, Ravi A wrote: > >> Andy Walls wrote: >> >>>> Hi Andy, >>>> >>>> I did some more testing comparing the patches. The dropouts appear to >>>> be because of the VCO related patches. The versions before the VCO >>>> center frequency patch do not show this issue. I was mislead earlier >>>> (into thinking all the versions had the dropouts) as I was just doing >>>> an unload and load to move across versions - this does not seem to be >>>> clean, the register writes may not be completely reset. If I do a cold >>>> boot in between, then with pre-VCO version I am able to see that there >>>> are no dropouts. I also checked the patches you submitted to the >>>> staging repository and there seem to be no dropouts with this too. >>>> >>>> I will continue to do more testing to double-check. Let me know if you >>>> think the above is reasonable. >>>> >>>> >>> Ravi, >>> >>> I'm going to leave the cx25840 module alone for now. I really don't >>> have time to chase problems with changing the VCO operation and it >>> wasn't needed to get your card working (AFAICT). >>> >>> My pull reuqest only include the changes needed for you card (so far) >>> and the PARTSNIC tuner. >>> >>> So what's left? You said you had some noisy/weak audio right? I'll try >>> to add the v4l2-dbg support to the wm8739 module sometime this weekend. >>> I'm essentially going to mimic the implementation in the cs5345 module. >>> That way, you'll be able to experiment with wm8739 settings. >>> >>> Regards, >>> Andy >>> >>> >>> >>>> Regards >>>> Ravi >>>> >>>> >>> >>> >> Hi Andy, >> >> Thanks. >> >> Yes, the VCO change was not needed for me to use my card. >> >> About the audio, it is not too bad, but it could be made much better >> if the gain in WM8739 is increased. Currently it does not seem to be >> using the full scale range of the ADC, and besides, there is >> attenuation on the board too, so the final output is pretty low. >> Increasing the WM8739 volume should help to boost the SNR a lot. I can >> experiment with the settings once you add the WM8739 support. >> > > Ravi, > > Please test the latest patch at > > http://linuxtv.org/hg/~awalls/ivtv > > it adds a secondary set of user controls for manipulating the WM8739 > audio controls via v4l2-ctl. You will see controls named > "secondary_volume", "secondary_mute", etc. > > Hans, > > If these control settings are usable for Ravi, can you please comment on > the patch. It was the simplest way I could think of to effect the > change in a very generic way, that should work for any ivtv card. But > looking at it, I get the sense it could possibly be improved. > > >> The other issue I am seeing is the Composite input quality which I >> mentioned sometime back. There are jagged edges in red/yellow and >> sometimes white edges. Moving text is very jagged too. I think it may >> have something to do with the internal de-interlacing in the card, but >> I have no clue. I plan to try some register settings tomorrow. The >> S-Video input does not seem to have this problem and gives crystal >> clear picture. >> > > I don't have any thought on this at the moment. Life got busy recently. > > > Regards, > Andy > > >> Regards >> Ravi >> >> >> >> >> > >
Hi Andy, Thanks for your help on this. Being able to set these as secondary controls is a good idea! Unfortunately I am on travel for about a week, so I can get to test this only towards the end of next week. Will report back to you on these settings as soon as I return. Regards Ravi _______________________________________________ ivtv-devel mailing list [email protected] http://ivtvdriver.org/mailman/listinfo/ivtv-devel
