On Tue, 8 Feb 2011, Andy Walls wrote:
> I'm still reviewing this one, but I found one problem. See below.
> > + if (y_pages != y_dma.page_count || uv_pages != uv_dma.page_count) {
> > + int rc = -EINVAL;
>
> rc has scope of only this 'if' block, but ...
> > - dma->page_count = 0;
> > - return -EINVAL;
> > }
>
> rc doesn't appear to be return'ed.
Oops. I'd gone back and forth between setting rc and returning the error
code in-place. I went only halfway forth the last time.
I'll regenerate the patch with the return, and the two added for loops
de-braced.
--
Paul Cassella
_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
