On Thu, 2005-02-24 at 18:39, D. Hugh Redelmeier wrote:
> [I recommend that folks quote only relevant parts of previous
> messages. That makes for shorter messages that are easier to read.]
Oops.. sorry!
> | From: Jelte van der Hoek <[EMAIL PROTECTED]>
> |
> | I made a change to the cx25840 driver that changes the seq arrays to
> | function calls (and uses an additional array to buffer the settings), I
> | was still testing this but it seems to work. I don't have time to make a
> | patch against the 0.3.2e and test it right now, but I'll do it tonight
> | after I can test it.
>
> Do you know if that change is worthwhile? How big are those arrays?
> In some cases, you are moving work from compile time to runtime -- not
> a great tradeoff.
The arrays are big enough to crash the kernel when the driver activates.
My current patch runs fine on FC3 with REGPARMS and 4KSTACKS. The array
I added is smaller than the two debug arrays currently in cx25840_state.
-- 8<--
struct cx25840_state {
:
/** Stores the desired state of each register. Dirty registers may
still need to be updated. */
u8 reg_cache[number_of_registers];
/** Stores a dirty bit for each register. */
u8 reg_dirty[(number_of_registers+7)/8];
-- 8< --
I just changed the macros used in the arrays slightly to call a function
instead of produce a value. I wanted to allow an #ifdef to control
whether to use the 'old' way and the new way. But I departed from this
in the meantime plus I added a STRING=VALUE test ioctl which makes the
patch bigger than it needs to be. This is why I'm having some trouble
making a new clean patch. (The old patch I sent to the list, but it was
too big and the mail was held for 'moderation', after which I never
heard back. Anyway, that's too late now I guess)
I also have an additional problem which is that I did an apt-get upgrade
to mythtv-0.17 after which Live TV stopped working (times out opening
the capture), but capture still works with mplayer /dev/video0. Then I
attempted to downgrade to 0.16 but it still does not work.
Anyway, it'll take me some more time to make the patch again. In the
meantime, if you want to have a look I put the main changed files here:
http://vanderhoek.org/jelte/cx25840-0.3.2d-patched-by-jelte.tgz
Cheers,
-Jelte
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
ivtv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ivtv-devel
