On Mon, May 23, 2005 at 05:20:21PM -0400, Bryan Mayland wrote:
> Bryan Mayland wrote:
> > of that, ~4.5 seconds are spent uploading the audio firmware
> 
> You might find this interesting.  When uploading the firmware in the 
> hauppauge windows driver, the i2c algo udelay is set to 3us instead of 
> the normal 10us.

I contaced Hauppauge engineering and asked about this. This was done
in older code and was abandonded due to problems (I have no
information about the nature of the problems).

But the 4.5 seconds do look wrong, theroretically this should ba at
about 1.2 even at only a 100KHz speed (see my other post in this
thread).

> Adding this quick function:
> static void cx25840_set_i2c_delay(struct i2c_client *client, int delay)
> {
>         struct i2c_algo_bit_data *algod = client->adapter->algo_data;
>         algod->udelay = delay;
> }
> 
> and setting it to 3 during the firmware load reduces my module load time 
> from ~7.9s to ~5.2s.  After the firmware is sent, I return the udelay to 
> 10.  Any reason we shoudn't do this like the windows driver does?

We can try to, but if Hauppauge abandoned this, it looks like there
will be cases where this will not work properly.

Perhaps with a module parameter defaulting to not changing the delay?
-- 
Axel.Thimm at ATrpms.net

Attachment: pgpKRqdigEmL5.pgp
Description: PGP signature

Reply via email to