[ivtv-devel] [PATCH] more robust pal/secam argument check

[Philip Rowlands]

- tuner/tda9887: print warning if unsupported parameter given

If unrecognised (or typo) arguments are passed to the pal= or secam=
parameters, a warning will be printed. Tested, works for me.


Cheers,
Phil
diff -ru ivtv-0.3.7h.orig/driver/tda9887.c ivtv-0.3.7h/driver/tda9887.c
--- ivtv-0.3.7h.orig/driver/tda9887.c   2005-08-16 12:31:30.000000000 +0100
+++ ivtv-0.3.7h/driver/tda9887.c        2005-08-22 05:06:17.000000000 +0100
@@ -541,6 +541,12 @@
                        dprintk(PREFIX "insmod fixup: PAL => PAL-DK\n");
                        t->std = V4L2_STD_PAL_DK;
                        break;
+               case '-':
+                       /* default parameter, do nothing */
+                       break;
+               default:
+                       printk(PREFIX "pal= argument not recognised\n");
+                       break;
                }
        }
        if ((t->std & V4L2_STD_SECAM) == V4L2_STD_SECAM) {
@@ -557,6 +563,12 @@
                        dprintk(PREFIX "insmod fixup: SECAM => SECAM-L\n");
                        t->std = V4L2_STD_SECAM_L;
                        break;
+               case '-':
+                       /* default parameter, do nothing */
+                       break;
+               default:
+                       printk(PREFIX "secam= argument not recognised\n");
+                       break;
                }
        }
        return 0;
diff -ru ivtv-0.3.7h.orig/driver/tuner.c ivtv-0.3.7h/driver/tuner.c
--- ivtv-0.3.7h.orig/driver/tuner.c     2005-08-16 12:31:30.000000000 +0100
+++ ivtv-0.3.7h/driver/tuner.c  2005-08-22 05:05:03.000000000 +0100
@@ -1529,6 +1529,12 @@
                        dprintk("insmod fixup: PAL => PAL-DK\n");
                        t->std = V4L2_STD_PAL_DK;
                        break;
+               case '-':
+                       /* default parameter, do nothing */
+                       break;
+               default:
+                       printk("tuner: pal= argument not recognised\n");
+                       break;
                }
        }
        return 0;