On Monday 10 November 2008 09:24:44 Alexander Pipelka wrote:
> Hi,
>
> Are there any news on the B-Frame issue.
> I sent a status log ~ 3 weeks ago.
Hi Alex,
I looked at it today and I could reproduce it. I also found what the
difference is between the old and current ivtv driver. When you pass
the B-frames to the card the API says that you should pass B+frames + 1
to the card. So if there are 0 B-frames, then the number should be 0+1
= 1. However, for some reason that does not seem to work for a
cx2584x-based card. If I put in 0 instead of 1, then it works again.
What I don't know is if that really produces a stream without B-frames.
Applying the attached patch should fix the problem you have, but I
wonder if you can also test the presence of B/I/P frames and check that
you get the right results (i.e. really 0 B-frames). I can also test it,
but not easily and not until after two weeks from now.
Regards,
Hans
diff -r eae94cab8ab9 linux/drivers/media/video/cx2341x.c
--- a/linux/drivers/media/video/cx2341x.c Sat Nov 01 12:25:11 2008 +0100
+++ b/linux/drivers/media/video/cx2341x.c Mon Nov 10 22:52:50 2008 +0100
@@ -880,7 +880,7 @@
}
if (force || NEQ(video_b_frames) || NEQ(video_gop_size)) {
err = cx2341x_api(priv, func, CX2341X_ENC_SET_GOP_PROPERTIES, 2,
- new->video_gop_size, new->video_b_frames + 1);
+ new->video_gop_size, new->video_b_frames ? new->video_b_frames + 1 : 0);
if (err) return err;
}
if (force || NEQ(video_gop_closure)) {
_______________________________________________
ivtv-users mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-users
