Awesome. Works great. Thanks for your help.


On 06/06/2014 07:43 AM, Scott Robinson wrote:
That did the trick. Many thanks Devin.

Scott

--- a/drivers/media/pci/cx18/cx18-driver.c    2013-09-02
15:46:10.000000000 -0500
+++ b/drivers/media/pci/cx18/cx18-driver.c    2014-06-03
13:46:22.829080613 -0500
@@ -1081,7 +1081,7 @@ static int cx18_probe(struct pci_dev *pc

      if (cx->options.tuner > -1) {
          struct tuner_setup setup;
-
+                memset(&setup, 0, sizeof(struct tuner_setup));
          setup.addr = ADDR_UNSET;
          setup.type = cx->options.tuner;
          setup.mode_mask = T_ANALOG_TV;  /* matches TV tuners */



On Sun, Jun 1, 2014 at 7:20 PM, Devin Heitmueller
<[email protected]> wrote:
No, never got around to it.

Working from memory, but try adding a memset to cx18-driver.c, line 1090 for
the tuner_setup struct:

memset(&setup, 0, sizeof(struct tuner_setup));

I'm pretty sure that will do it.

Devin


On Sun, Jun 1, 2014 at 4:45 PM, Scott Robinson <[email protected]>
wrote:
Have you posted the patch? If so, please provide a link.  If not,
would you point me to the correct file, line to insert the memset?

Many thanks,
Scott


On Sun, Apr 27, 2014 at 9:27 AM, Devin Heitmueller
<[email protected]> wrote:
On Sun, Apr 27, 2014 at 8:52 AM, Andy Walls <[email protected]>
wrote:
On Thu, 2014-04-17 at 06:03 -0400, Chris Florian wrote:
Any update on this?
Sadly, no.

Between tax season requirements for my business, new employees,
customer
proposals and deadlines, and my wife and kids; I have had no time to
fix
this for months. :(  My prospects for free time in the coming months
look bleak as well.

I can easily sign off on a proper patch submitted to
[email protected] ; if anyone is so inclined.
I actually chased this down a few weeks ago but haven't submitted a
patch upstream yet.  It's a simple use of uninitialized memory that
occurs when the s_type_addr() call gets made.  Memset the tuner_struct
before calling s_type_addr and the issue goes away.

Or hold off and I'll submit a patch next week when I'm at ELC.

Devin

--
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

_______________________________________________
ivtv-users mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-users
_______________________________________________
ivtv-users mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-users



--
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

_______________________________________________
ivtv-users mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-users
_______________________________________________
ivtv-users mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-users


--
footer.html _ Chris Florian |TXIO Corporation|www.txio.ca <http://www.txio.ca> | 1.416.414.6378 _
_______________________________________________
ivtv-users mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-users

Reply via email to