Refactoring / documentation / test of matcher package
-----------------------------------------------------
Key: IVY-375
URL: https://issues.apache.org/jira/browse/IVY-375
Project: Ivy
Issue Type: Improvement
Components: Core
Affects Versions: 1.4.1
Reporter: Stephane Bailliez
Priority: Trivial
Attachments: matcher-src.patch
Objective was to cleanup slightly the code by documenting the exact intent of
the interface and methods to provide a consistent implementation.
Implementation has been adjusted to match it:
- Does not support null input
- Does not support null expression
- Remove getInstance() method in favor of INSTANCE public static final field.
- Remove unused method
- Javadoc documentation where appropriate (it's not full-fledged, but eh.. Rome
was not made in a day
- Added testcases for all pattern matchers
- Added // TODO notes for long-term mental notes
The change is overall minor and have little impact to the rest of the code.
I expect some slight API adjustements later on but this is enough for now.
Let me know if there are issues and if I forgot something in the patches.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
