[
https://issues.apache.org/jira/browse/IVY-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Coene resolved IVY-435.
-------------------------------
Resolution: Fixed
Fix Version/s: 1.5
Changed javadoc on sort() method and updated the
AbstractLatestStrategy.findLatest() method which assumed the latest revision
came first.
This bug in the findLatest() method wasn't noticed because the
ComparatorLatestStrategy overrides this method. Since this isn't necessary (it
is already implemented in the AbstractLatestStrategy class and I didn't see any
performance optimisations in the subclass), I've removed this method in the
ComparatorLatestStrategy class.
> LatestRevisionStrategy.sort() doesn't sort as specified
> -------------------------------------------------------
>
> Key: IVY-435
> URL: https://issues.apache.org/jira/browse/IVY-435
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Reporter: Maarten Coene
> Assigned To: Maarten Coene
> Fix For: 1.5
>
>
> According to the LatestStrategy.sort() javadoc, the sort method should sort
> the artifacts from latest to oldest.
> However, the LatestRevisionStrategy.sort() method does the opposite!
> The following junit test shows this (add to LatestRevisionStrategyTest.java):
> {code}
> public void testSort() {
> ArtifactInfo[] revs = toMockAI(new String[] {
> "0.2a",
> "0.2_b",
> "0.2rc1",
> "0.2-final",
> "1.0-dev1",
> "1.0-dev2",
> "1.0-alpha1",
> "1.0-alpha2",
> "1.0-beta1",
> "1.0-beta2",
> "1.0-gamma",
> "1.0-rc1",
> "1.0-rc2",
> "1.0",
> "1.0.1",
> "2.0"
> });
>
> List shuffled = new ArrayList(Arrays.asList(revs));
> ArtifactInfo[] shuffledRevs = (ArtifactInfo[]) shuffled.toArray(new
> ArtifactInfo[revs.length]);
>
> LatestRevisionStrategy latestRevisionStrategy = new
> LatestRevisionStrategy();
> List sorted = latestRevisionStrategy.sort(shuffledRevs);
> assertEquals(Arrays.asList(revs), sorted);
> }
> {code}
> The question is: should we change the javadoc or the
> LatestRevisionStrategy.sort method?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
