[
https://issues.apache.org/jira/browse/IVY-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493111
]
Xavier Hanin commented on IVY-493:
----------------------------------
Thanks for your contribution, Gilles!
Some little things about your patch:
- AFAIK, in english there is no space before a column (e.g. "Sort done for : "
should better be "Sort done for: ")
- I think your modifications on the test case are a bit too much. Indeed I
think we loose some level of testing on the circular dependency tests for
instance. Maybe what can be done is keep tests as they were and add one test
method (e.g. testSortWithVersionConstraint) to test this issue case.
WDYT?
> buildlist broken
> ----------------
>
> Key: IVY-493
> URL: https://issues.apache.org/jira/browse/IVY-493
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.0-alpha-1
> Reporter: Gilles Scokart
> Priority: Critical
> Fix For: 2.0.0-alpha-2
>
> Attachments: IVY-493.patch
>
>
> buildlist doesn't sort the modules anymore in 2.0-alpha1 when local ivy files
> doesn't contains a revision.
> I traced back the problem to the ModuleDescriptorSorter that was asuming that
> the revision is null in such a case, while it is now '[EMAIL PROTECTED]'.
> I will post the patch soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
