Refactor Message class
----------------------
Key: IVY-496
URL: https://issues.apache.org/jira/browse/IVY-496
Project: Ivy
Issue Type: Wish
Components: Core
Affects Versions: unspecified
Reporter: Gilles Scokart
Priority: Minor
The class Message does to much things. Namely,
- It implements a kind default MessageImpl as fallback when no MessageImpl
are defined (use System.err).
- It accumulate warnings and errors until sumupProblems is invoked
For the first point, Message should be refactored to use the DefaultMessageImpl
by default.
The second point is more problématic. The accumation of warnings/error in
Message itself make the unit test more difficult to isolate (warning/error
messages are kept between tests). Moreover, at runtime, I fear that there is a
risk of silently (I should say 'verbosly') ignores errors and warnings messages
when sumupProblems is not invoked (for example because of an exception or, just
because this method is not invoked at all).
When searching to who invoke sumupProblems, I found only resolverManager and
conflict manager. So I'm not sure what is the best refactoring aproach :
- Should we put the accumultation in the AntMessageImpl, and invoke
sumupProblems from the ant task (the same that put AntMessageImpl as the
implementation to use)
- Or should we move the accumulation of errors/warning into a dedicated class
used by the code invked by the resolveManager/confiltManager.
WDYT?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
